Skip to content

[Az.Search] 2025 05 01 RP API Support #28623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

[Az.Search] 2025 05 01 RP API Support #28623

merged 2 commits into from
Oct 20, 2025

Conversation

@Draconicida
Copy link
Member

@Draconicida Draconicida commented Sep 30, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings September 30, 2025 00:25
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 30, 2025

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot AI reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@Draconicida Draconicida changed the title Search 2025 05 01 support [Az.Search] 2025 05 01 RP API Support Sep 30, 2025
@isra-fel
Copy link
Member

isra-fel commented Sep 30, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Sep 30, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@Draconicida
Copy link
Member Author

Draconicida commented Sep 30, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Sep 30, 2025

Commenter does not have sufficient privileges for PR 28623 in repo Azure/azure-powershell

@VeryEarly VeryEarly self-assigned this Sep 30, 2025
VeryEarly
VeryEarly previously requested changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes under azure-powershell/generated and azure-powershell/src/DataMigration are irrelevant to your PR, please properly rebase your branch, thanks

@VeryEarly
Copy link
Collaborator

VeryEarly commented Sep 30, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Sep 30, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@Draconicida Draconicida force-pushed the search-2025-05-01-support branch from 44dc635 to addf7dc Compare September 30, 2025 05:59
@Draconicida
Copy link
Member Author

Draconicida commented Sep 30, 2025

Removed the unrelated changes and rebased to squash the commits into one.

@github-actions github-actions bot mentioned this pull request Oct 1, 2025
Closed
@isra-fel
Copy link
Member

isra-fel commented Oct 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 2, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 2, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 3, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 3, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@Draconicida Draconicida force-pushed the search-2025-05-01-support branch from 3660ee5 to 2935c86 Compare October 3, 2025 05:07
@Draconicida
Copy link
Member Author

Draconicida commented Oct 7, 2025

@isra-fel could you please kick off the pipelines again? Thanks!

@VeryEarly
Copy link
Collaborator

VeryEarly commented Oct 9, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 9, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@Draconicida
Copy link
Member Author

Draconicida commented Oct 14, 2025

@VeryEarly @isra-fel, the pipeline checks all passed, the requested changes are committed. May I ask for an approval on this PR?

@isra-fel isra-fel requested a review from Copilot October 15, 2025 02:10
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 57 out of 183 changed files in this pull request and generated 5 comments.

isra-fel
isra-fel requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two questions

@isra-fel isra-fel assigned Draconicida and unassigned VeryEarly Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@Draconicida Draconicida assigned isra-fel and unassigned Draconicida Oct 15, 2025
@Draconicida
Copy link
Member Author

Draconicida commented Oct 15, 2025

LGTM with two questions

Addressed the comments in the latest commit.

@isra-fel
Copy link
Member

isra-fel commented Oct 15, 2025

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 15, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@Draconicida
Copy link
Member Author

Draconicida commented Oct 16, 2025

@isra-fel, could you please take another look? Thanks!

@isra-fel isra-fel dismissed VeryEarly’s stale review October 20, 2025 02:59

unwanted changes removed

@isra-fel isra-fel merged commit 5328305 into Azure:main Oct 20, 2025
12 checks passed
@isra-fel isra-fel mentioned this pull request Oct 27, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@isra-fel isra-fel isra-fel approved these changes

@VeryEarly VeryEarly VeryEarly left review comments

Assignees

@isra-fel isra-fel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Draconicida @isra-fel @VeryEarly